Why won't this work?

[Saffire]

Code:

!action
give
!test
event[:to] == self
!reaction
item = event[:item].downcase
"say #{item.name}"

For some reason the give action isn't firing at all, and I can't figure out why

[Justin]

event[:to] will be the actual text from the command. All events should be standardized so that event[:target] will be the receiver of the action, so use that instead. Or object_is_me? event which does the same thing.

[Saffire]

It still doesn't work when I use object_is_me? event. I had originally used event[:to] because of this line in components/commandparser:

when /^give\s+((\w+\s*)*)\s+to\s+(\w+)/i
{ :action => :give, :item => $2.strip, :to => $3 }

[Justin]

Yes, but that is just the text. The event which is actually sent to the object will be from the Generic::give method, which will set event[:target].

However, looking at your reaction more closely, the problem is likely because you are doing item.name when item just a string from the command. So it is causing an error when it runs the reaction. If you watch the server's output while trying to get the object to react, you will (probably?) see the error message.

Which makes me think I should make it so those errors show up in the logs.

[Saffire]

Hmm, you're right, of course

I'm hosting the server on another computer in the back room, so it's a bit of a pain to go and look at it, and I just took for granted that any pertinent debugging info would be sent to the logs, and that's what was throwing me off.

Thanks for the help, it's fixed now

[Justin]

Okay, here is an update for logging reaction errors.

I'd also recommend adding this and removing this so that the logs displaying in the game are up-to-date.

[Saffire]

All right, I've got the new code. I'll let you know if I find any problems.

And thanks for your help tonight.

[Saffire]

Are you having problems with your message boards after these changes? For some reason after these changes when I try to save a message I've written on my message board it lags the MUD for 2 or 3 minutes and then it finally starts going again and posts the message. Any ideas?

[Justin]

I'm not seeing that happen. Kind of hard to see why these changes would cause that...unless you are getting an error that causing a gigantic amount of logs (from the backtrace). I would check the server output directly.